public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 4/4] tst_atomic: add test for tst_atomic_inc
Date: Wed, 13 Apr 2016 16:15:51 +0200	[thread overview]
Message-ID: <20160413141551.GD11529@rei.lan> (raw)
In-Reply-To: <c7a40e44c496051bedb3c8af46d16d42c50c49af.1460552890.git.jstancek@redhat.com>

Hi!
This is nice to have ;)

> +/*
> + * Copyright (c) 2016 Linux Test Project
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it would be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + */
> +
> +/*
> + * Test that tst_atomic_inc works as expected.
> + */
> +
> +#include <pthread.h>
> +#include "tst_test.h"
> +
> +#define THREADS 64
> +#define ITERATIONS 100000
> +
> +static int atomic;
> +
> +static void *worker(void *id)
> +{
> +	int i;
> +
> +	(void) id;
> +	for (i = 0; i < ITERATIONS; i++)
> +		tst_atomic_inc(&atomic);
> +
> +	return NULL;
> +}
> +
> +static void do_test(void)
> +{
> +	long i;
> +	pthread_t threads[THREADS];
> +
> +	for (i = 0; i < THREADS; i++)
> +		pthread_create(threads+i, NULL, worker, (void *)i);
> +
> +	for (i = 0; i < THREADS; i++) {
> +		tst_res(TINFO, "Joining thread %li", i);
> +		pthread_join(threads[i], NULL);
> +	}
> +
> +	if (atomic == THREADS * ITERATIONS)
> +		tst_res(TPASS, "Atomic working as expected");
> +	else
> +		tst_res(TFAIL, "Atomic does not have expected value");
> +}
> +
> +static struct tst_test test = {
> +	.tid = "test09",
> +	.test_all = do_test,
> +	.forks_child = 1

Looks like the forks_child is copy&pasted from test08 which was
copy&pasted test07 which really forks a child. I will fix test08.c and
you should remove it from this one as well.
`
> +};

-- 
Cyril Hrubis
chrubis@suse.cz

  reply	other threads:[~2016-04-13 14:15 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-13 13:10 [LTP] [PATCH 1/4] tst_atomic: make tst_atomic_inc take a signed integer Jan Stancek
2016-04-13 13:10 ` [LTP] [PATCH 2/4] m4: add a check for __sync_add_and_fetch Jan Stancek
2016-04-13 14:04   ` Cyril Hrubis
2016-04-13 13:10 ` [LTP] [PATCH 3/4] tst_atomic: add atomic_add_return for x86/64, ppc/64 and s390/x Jan Stancek
2016-04-13 13:59   ` Cyril Hrubis
2016-04-13 14:36     ` Jan Stancek
2016-04-13 15:03       ` Cyril Hrubis
2016-04-13 13:10 ` [LTP] [PATCH 4/4] tst_atomic: add test for tst_atomic_inc Jan Stancek
2016-04-13 14:15   ` Cyril Hrubis [this message]
2016-04-13 14:07 ` [LTP] [PATCH 1/4] tst_atomic: make tst_atomic_inc take a signed integer Cyril Hrubis
2016-04-13 14:32   ` Jan Stancek
2016-04-13 15:33     ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160413141551.GD11529@rei.lan \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox