From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 3/4] tst_atomic: add atomic_add_return for x86/64, ppc/64 and s390/x
Date: Wed, 13 Apr 2016 17:03:11 +0200 [thread overview]
Message-ID: <20160413150310.GH10941@rei.lan> (raw)
In-Reply-To: <165775875.873245.1460558166172.JavaMail.zimbra@redhat.com>
Hi!
> > > +#if defined(__i386__) || defined(__x86_64__)
> > > +#define HAVE_ATOMIC_ADD_RETURN 1
> > > +extern void __xadd_wrong_size(void);
> > > +static inline __attribute__((always_inline)) int atomic_add_return(int i,
> > > int *v)
> > > +{
> > > + int __ret = i;
> > > +
> > > + switch (sizeof(*v)) {
> > > + case 1:
> > > + asm volatile ("lock; xaddb %b0, %1\n"
> > > + : "+q" (__ret), "+m" (*v) : : "memory", "cc");
> > > + break;
> > > + case 2:
> > > + asm volatile ("lock; xaddw %w0, %1\n"
> > > + : "+r" (__ret), "+m" (*v) : : "memory", "cc");
> > > + break;
> >
> > Do we really need byte and word version? As far as I can tell int is 4
> > bytes on x86 and x86_64 and unlike kernel where this is a macro we
> > cannot pass anything else than int.
I would say that we should remove this part as it's effectively dead
code. But if you really think that we should preserve it I'm fine with
that as well.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2016-04-13 15:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-13 13:10 [LTP] [PATCH 1/4] tst_atomic: make tst_atomic_inc take a signed integer Jan Stancek
2016-04-13 13:10 ` [LTP] [PATCH 2/4] m4: add a check for __sync_add_and_fetch Jan Stancek
2016-04-13 14:04 ` Cyril Hrubis
2016-04-13 13:10 ` [LTP] [PATCH 3/4] tst_atomic: add atomic_add_return for x86/64, ppc/64 and s390/x Jan Stancek
2016-04-13 13:59 ` Cyril Hrubis
2016-04-13 14:36 ` Jan Stancek
2016-04-13 15:03 ` Cyril Hrubis [this message]
2016-04-13 13:10 ` [LTP] [PATCH 4/4] tst_atomic: add test for tst_atomic_inc Jan Stancek
2016-04-13 14:15 ` Cyril Hrubis
2016-04-13 14:07 ` [LTP] [PATCH 1/4] tst_atomic: make tst_atomic_inc take a signed integer Cyril Hrubis
2016-04-13 14:32 ` Jan Stancek
2016-04-13 15:33 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160413150310.GH10941@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox