From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] waitpid/waitpid10: break test if fork failed
Date: Tue, 19 Apr 2016 15:07:12 +0200 [thread overview]
Message-ID: <20160419130712.GA21282@rei.lan> (raw)
In-Reply-To: <20160414053923.GH17476@localhost.localdomain>
Hi!
> @@ -330,6 +331,8 @@ int main(int ac, char **av)
> }
> }
>
> + memset(fork_kid_pid, 0, sizeof(fork_kid_pid));
If you memset the array here the test will fail since it's used in the
loop below to check the results.
And looking at the test code it's broken beyond repair. It would likely
be easier to rewrite it from scratch than trying to fix all problems it
has.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2016-04-19 13:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-13 7:11 [LTP] [PATCH] waitpid/waitpid10: break test if fork failed Han Pingtian
2016-04-13 12:36 ` Cyril Hrubis
2016-04-14 5:39 ` Han Pingtian
2016-04-19 13:07 ` Cyril Hrubis [this message]
2016-04-25 7:41 ` Han Pingtian
2016-05-12 1:30 ` Han Pingtian
2016-05-12 15:07 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160419130712.GA21282@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox