From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] clone/clone07: only kill child if clone() succeeded
Date: Tue, 19 Apr 2016 18:44:16 +0200 [thread overview]
Message-ID: <20160419164416.GD21282@rei.lan> (raw)
In-Reply-To: <20160414084633.GA16717@localhost.localdomain>
Hi!
> static void cleanup(void)
> {
> - kill(child_pid, SIGKILL);
> + if (child_pid > 0)
> + kill(child_pid, SIGKILL);
> }
Looking at the code, the child does just return 0 (which exits the child
process). There is no need to kill the child_pid in cleanup at all. So
I've removed the cleanup function and pushed, thanks.
--
Cyril Hrubis
chrubis@suse.cz
prev parent reply other threads:[~2016-04-19 16:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-14 8:46 [LTP] [PATCH] clone/clone07: only kill child if clone() succeeded Han Pingtian
2016-04-19 16:44 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160419164416.GD21282@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox