From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [RFC][PATCH 1/3] network: run network tests from network.sh
Date: Mon, 16 May 2016 14:47:11 +0200 [thread overview]
Message-ID: <20160516124711.GD6454@rei.lan> (raw)
In-Reply-To: <20160516123103.GC6454@rei.lan>
Hi!
> This does not say what is the reason for this change.
>
> How is this better than runing runtest files from runltp?
>
> You supposedly define a few variables in the script that starts the
> testcases rather than having a common script that is sourced at the
> start of the network testcases. Is there any other thing I'm missing?
Looking into the networkstress.sh and networktest.sh it starts ltp-pan
itself as well. So this more or less copies the functionality from there
to network.sh.
I would say that the defaults for variables should not be defined in the
script that runs selected (subset of) tests. That is because it should
be possible to run just the test script and expect it to have the same
defaults as when it's executed via the script. Why don't we stick the
defaults to test_net.sh and keep just the code that selects testcases
to run and start ltp-pan in the network.sh?
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2016-05-16 12:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-10 8:46 [LTP] [RFC][PATCH 1/3] network: run network tests from network.sh Alexey Kodanev
2016-05-10 8:46 ` [LTP] [RFC][PATCH 2/3] network: remove outdated network runtests and scripts Alexey Kodanev
2016-05-10 8:46 ` [LTP] [RFC][PATCH 3/3] network: rename runtest files, use 'net.' & 'net_stress.' prefix Alexey Kodanev
2016-05-16 12:31 ` [LTP] [RFC][PATCH 1/3] network: run network tests from network.sh Cyril Hrubis
2016-05-16 12:47 ` Cyril Hrubis [this message]
2016-05-16 13:57 ` Alexey Kodanev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160516124711.GD6454@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox