From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 1/3] network: merge networktests.sh/networkstress.sh into network.sh
Date: Tue, 17 May 2016 15:53:45 +0200 [thread overview]
Message-ID: <20160517135345.GF12051@rei.lan> (raw)
In-Reply-To: <573B1822.3030601@oracle.com>
Hi!
> But if we don't source test.sh we will break some dependencies between
> test_net.sh and test.sh,
> e.g. variables like this one:
>
> export RHOST_HWADDRS=${RHOST_HWADDRS:-"$(tst_get_hwaddrs rhost)"}
>
> It might call tst_brkm/tst_resm...
Ah, missed that one. Then we should go with the v2.
> BTW, if we already using tst_* functions from test.sh, may be we could
> replace network.sh's 'echo' commands there too?
Hmm, that may be a bit confusing since that would make the output look
like an output from a testcase.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2016-05-17 13:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-17 9:02 [LTP] [PATCH v2 1/3] network: merge networktests.sh/networkstress.sh into network.sh Alexey Kodanev
2016-05-17 9:02 ` [LTP] [PATCH v2 2/3] network: remove outdated network runtests and scripts Alexey Kodanev
2016-05-17 9:02 ` [LTP] [PATCH v2 3/3] network: rename runtest files, use 'net.' & 'net_stress.' prefix Alexey Kodanev
2016-05-17 12:29 ` [LTP] [PATCH v2 1/3] network: merge networktests.sh/networkstress.sh into network.sh Cyril Hrubis
2016-05-17 13:09 ` Alexey Kodanev
2016-05-17 13:53 ` Cyril Hrubis [this message]
2016-05-19 9:54 ` Alexey Kodanev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160517135345.GF12051@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox