From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2] creat05: don't assume number of opened fds
Date: Tue, 17 May 2016 17:01:55 +0200 [thread overview]
Message-ID: <20160517150155.GH12051@rei.lan> (raw)
In-Reply-To: <28627e5e1631723fccf734af32372e7fa4655ce7.1463496559.git.jstancek@redhat.com>
Hi!
> - if (last_fd <= 0)
> + if (num_opened_fds == 0)
> return;
We can leave out this if now since the for would be no-op now.
> - for (fd = first_fd + 1; fd <= last_fd; fd++) {
> - if (close(fd))
> - tst_res(TWARN | TERRNO, "close(%i) failed", fd);
> + for (i = 0; i < num_opened_fds; i++) {
> + if (close(opened_fds[i])) {
> + tst_res(TWARN | TERRNO, "close(%i) failed",
> + opened_fds[i]);
> + }
> }
We may also free the allocated array here.
> }
Otherwise it looks good, acked.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2016-05-17 15:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-17 14:50 [LTP] [PATCH v2] creat05: don't assume number of opened fds Jan Stancek
2016-05-17 15:01 ` Cyril Hrubis [this message]
2016-05-17 15:13 ` Jan Stancek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160517150155.GH12051@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox