From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] Fwd: pwrite04 ltp bug?
Date: Mon, 23 May 2016 17:43:53 +0200 [thread overview]
Message-ID: <20160523154353.GE25488@rei.lan> (raw)
In-Reply-To: <CAOg9mSQJF9gShs0m8osa7=idydmsacV1og78XCq=zitNH6aR9Q@mail.gmail.com>
Hi!
> > This does not look right...
>
> OK, I was just copying the file size test
> loop above the "Finally" comment, I assumed
> that cleanup exited. As it is, if you fail the
> file size loop I edited, you'll get both a FAIL
> and a PASS...
>
> Maybe in all the cases that resolve to FAIL
> we should goto some kind of out-fail: ?
The best solution would to move the actual test to a separate function
called from the for() loop in main(), then we can just do return in case
of failure.
--
Cyril Hrubis
chrubis@suse.cz
prev parent reply other threads:[~2016-05-23 15:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAOg9mSSjfxiZ960tpADgVmndxXQpC7ag9QZSz68NbdeGn+yW9g@mail.gmail.com>
[not found] ` <CADVQ27oBdCxfuVmknYa16RTXpnYgncn94VnutMgn2+9VD-9bcg@mail.gmail.com>
[not found] ` <CADVQ27q119e2Oqg0tVGDjc_8yjoXvQHbg=Tqd9n4jxu8tedRVg@mail.gmail.com>
2016-05-21 2:07 ` [LTP] Fwd: pwrite04 ltp bug? Mike Marshall
2016-05-23 12:39 ` Cyril Hrubis
2016-05-23 15:03 ` Mike Marshall
2016-05-23 15:43 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160523154353.GE25488@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox