From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] memcg/functional: check several times if the process is killed
Date: Mon, 23 May 2016 18:39:29 +0200 [thread overview]
Message-ID: <20160523163929.GG25488@rei.lan> (raw)
In-Reply-To: <57432F07.3040207@oracle.com>
Hi!
> > This does no seem right to me. The original code send a SIGUSR1 signal
> > to the memcg_process which caused it to allocate memory which supposedly
> > provokes OOM to kill it. Hence the sleep 1 after the kill -s USR $pid.
> >
> > Now this code hammers the memcg_process with SIGKILL instead.
> >
> > As far as I can tell the right thing to do here is to wait with
> > reasonable timeout for the memcg_process to become zombie and only kill
> > it if that hasn't happened. Or did I miss something?
>
> No, you didn't miss anything. I was planning to use 'kill' to check
> whether the pid is alive or not. But I should have used 'kill -s 0'
> instead of plain 'kill'.
Would that even work? Technically till you wait the process the pid
still exists albeit in a zombie state.
And looking into POSIX there were some systems that returned ESRCH in
this case but it looks this behavior is strongly discouraged.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2016-05-23 16:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-19 14:55 [LTP] [PATCH] memcg/functional: check several times if the process is killed Stanislav Kholmanskikh
2016-05-23 16:02 ` Cyril Hrubis
2016-05-23 16:25 ` Stanislav Kholmanskikh
2016-05-23 16:39 ` Cyril Hrubis [this message]
2016-05-23 17:43 ` Stanislav Kholmanskikh
2016-05-24 8:52 ` [LTP] [PATCH V2] " Stanislav Kholmanskikh
2016-05-24 12:26 ` Cyril Hrubis
2016-05-24 9:02 ` [LTP] [PATCH] " Jan Stancek
2016-05-24 9:18 ` Cyril Hrubis
2016-05-24 10:04 ` Stanislav Kholmanskikh
2016-05-24 10:15 ` Cyril Hrubis
2016-05-24 10:32 ` Jan Stancek
2016-05-24 10:48 ` Cyril Hrubis
2016-05-30 14:50 ` Stanislav Kholmanskikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160523163929.GG25488@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox