From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] memcg/functional: check several times if the process is killed
Date: Tue, 24 May 2016 11:18:19 +0200 [thread overview]
Message-ID: <20160524091819.GA10029@rei.lan> (raw)
In-Reply-To: <1653845167.258778.1464080543100.JavaMail.zimbra@redhat.com>
Hi!
> > > $TEST_PATH/memcg_process $2 -s $3 &
> > > pid=$!
> > > - sleep 1
> >
> > This sleep sure is useless.
>
> Isn't it there to make sure, that SIGUSR1 handler had time
> to set up? (for example with single CPU and sched_child_runs_first == 0)
Looking at the code, you are right.
We should better change this for something more robust. Given that the
memgc_progcess does while (!flag_exit) sleep(1); in the main loop we may
as well wait till the process gets into the sleep state.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2016-05-24 9:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-19 14:55 [LTP] [PATCH] memcg/functional: check several times if the process is killed Stanislav Kholmanskikh
2016-05-23 16:02 ` Cyril Hrubis
2016-05-23 16:25 ` Stanislav Kholmanskikh
2016-05-23 16:39 ` Cyril Hrubis
2016-05-23 17:43 ` Stanislav Kholmanskikh
2016-05-24 8:52 ` [LTP] [PATCH V2] " Stanislav Kholmanskikh
2016-05-24 12:26 ` Cyril Hrubis
2016-05-24 9:02 ` [LTP] [PATCH] " Jan Stancek
2016-05-24 9:18 ` Cyril Hrubis [this message]
2016-05-24 10:04 ` Stanislav Kholmanskikh
2016-05-24 10:15 ` Cyril Hrubis
2016-05-24 10:32 ` Jan Stancek
2016-05-24 10:48 ` Cyril Hrubis
2016-05-30 14:50 ` Stanislav Kholmanskikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160524091819.GA10029@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox