From: Li Wang <liwang@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 3/3] syscalls/madvise02: reconstruct and convert to new API
Date: Wed, 25 May 2016 14:17:40 +0800 [thread overview]
Message-ID: <20160525061740.GB32546@gmail.com> (raw)
In-Reply-To: <20160523141418.GB25488@rei.lan>
On Mon, May 23, 2016 at 04:14:18PM +0200, Cyril Hrubis wrote:
>
> This whole part is a mess. You should not change the content of the
> structure in this way. If there are values that has to be changed on the
> runtime the structure members should be initialized with a pointers to a
> variable and that variable should be set up in the setup().
Good proposals, but this situation are a little bit different.
I failed to decrease the lines of this part. Since madvise02 catch
failures on purpose. It is very hard to divide 'Not Support' with
'Expected Errno' when getting EINVAL msg.
So, I'd like to keep calling a tcases_filter() in test function to
make the testcase working correctly. And move an enable flag as a
global variable.
Patch V3 is coming...
Regards,
Li Wang
prev parent reply other threads:[~2016-05-25 6:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-23 4:59 [LTP] [PATCH v2 3/3] syscalls/madvise02: reconstruct and convert to new API Li Wang
2016-05-23 14:14 ` Cyril Hrubis
2016-05-25 6:17 ` Li Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160525061740.GB32546@gmail.com \
--to=liwang@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox