From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v1 1/1] test_robind: add "-f" mkfs option for xfs and btrfs
Date: Wed, 25 May 2016 16:10:12 +0200 [thread overview]
Message-ID: <20160525141011.GD17981@rei.lan> (raw)
In-Reply-To: <57454EC5.7050700@oracle.com>
Hi!
> >> Or we can move the dd that erases first blocks from tst_acquire_device()
> >> to tst_mkfs().
> >
> > I went to re-read why we are avoiding -f, and this does sound better
> > than adding -f back.
>
> If we move 'dd' to tst_mkfs(), then tst_acquire_device will return
> "uncleared" devices, and mkfs_ext* test cases from runtest/commands will
> start failing in our environment, i.e. we revert f79021c5d168256.
Well the mkfs testcase is special in a sense that it calls the mkfs
directly. So we may as well move the dd to tst_mfks() and do separate dd
in the mkfs testcase.
But doing 'git grep mkfs' reveals that we have more tests that call mkfs
directly and may start to fail in this case. :(
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2016-05-25 14:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 7:49 [LTP] [PATCH v1 1/1] test_robind: add "-f" mkfs option for xfs and btrfs Boyang Xue
2016-05-24 14:01 ` Jan Stancek
2016-05-24 15:26 ` Cyril Hrubis
2016-05-25 6:31 ` Jan Stancek
2016-05-25 7:05 ` Stanislav Kholmanskikh
2016-05-25 14:10 ` Cyril Hrubis [this message]
2016-06-17 4:28 ` Eryu Guan
2016-06-21 10:51 ` Stanislav Kholmanskikh
2016-06-21 10:59 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160525141011.GD17981@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox