From: Dong ZHu <bluezhudong@gmail.com>
To: ltp@lists.linux.it
Subject: [LTP] [Re-Send][PATCH] controllers/memcg: Mark testcase_2 as pass when mlock failed
Date: Wed, 1 Jun 2016 17:07:28 +0800 [thread overview]
Message-ID: <20160601090728.GA25827@localhost.localdomain> (raw)
In-Reply-To: <CAAUgArC7-C7tc2W5gpwt9=U_=gcU98uiLJci3xnjHDXjk8mUxg@mail.gmail.com>
There was a format issue in former mail, re-send this patch as below:
--8<--
While running "memcg_memsw_limit_in_bytes_test" always reported below error:
"memcg_memsw_limit_in_bytes_test 2 TFAIL : ltpapicmd.c:193: process 3769
is killed by error"
In function mmap_lock2() mlock failed to lock pages with errno EAGAIN,
the "memcg_process" process exit not the oom killer kill it.
Base on the this:
http://marc.info/?l=linux-mm&m=142122902313315&w=2
So mlock failed it is a expect behavior, in this case test should return
PASS.
Signed-off-by: Dong Zhu <bluezhudong@gmail.com>
---
testcases/kernel/controllers/memcg/functional/memcg_lib.sh | 3 +++
testcases/kernel/controllers/memcg/functional/memcg_process.c | 8 ++++++--
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/testcases/kernel/controllers/memcg/functional/memcg_lib.sh b/testcases/kernel/controllers/memcg/functional/memcg_lib.sh
index 9b9b0fd..2f889ab 100755
--- a/testcases/kernel/controllers/memcg/functional/memcg_lib.sh
+++ b/testcases/kernel/controllers/memcg/functional/memcg_lib.sh
@@ -229,8 +229,11 @@ test_proc_kill()
ps -p $pid > /dev/null 2> /dev/null
if [ $? -ne 0 ]; then
wait $pid
+ ret=$?
if [ $? -eq 1 ]; then
result $FAIL "process $pid is killed by error"
+ elif [[ $2 == "--mmap-lock2" ]] && [[ $ret -eq 0 ]]; then
+ result $PASS "process $pid exit, mlock failed to lock page return with errno EAGAIN"
else
result $PASS "process $pid is killed"
fi
diff --git a/testcases/kernel/controllers/memcg/functional/memcg_process.c b/testcases/kernel/controllers/memcg/functional/memcg_process.c
index 3d34394..dc33567 100644
--- a/testcases/kernel/controllers/memcg/functional/memcg_process.c
+++ b/testcases/kernel/controllers/memcg/functional/memcg_process.c
@@ -203,8 +203,12 @@ void mmap_lock2()
if (p == MAP_FAILED)
err(1, "mmap failed");
- if (mlock(p, memsize) == -1)
- err(1, "mlock failed");
+ if (mlock(p, memsize) == -1) {
+ if (errno == EAGAIN)
+ flag_exit = 1;
+ else
+ err(1, "mlock failed");
+ }
} else {
if (munmap(p, memsize) == -1)
err(1, "munmap failed");
--
2.1.0
--
Best Regards,
Dong Zhu
next prev parent reply other threads:[~2016-06-01 9:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-01 3:00 [LTP] [PATCH] controllers/memcg: Mark testcase_2 as pass when mlock failed Dong ZHu
2016-06-01 9:07 ` Dong ZHu [this message]
2016-06-01 9:36 ` [LTP] [Re-Send][PATCH] " Cyril Hrubis
2016-06-02 1:36 ` [LTP] [PATCH V2] " Dong ZHu
2016-06-06 1:20 ` Dong ZHu
2016-06-06 13:16 ` Cyril Hrubis
2016-06-07 1:44 ` [LTP] [PATCH V3] " Dong ZHu
2016-06-07 10:45 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160601090728.GA25827@localhost.localdomain \
--to=bluezhudong@gmail.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox