From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2] lib/tst_test.c: Run test in child process
Date: Wed, 8 Jun 2016 16:06:35 +0200 [thread overview]
Message-ID: <20160608140635.GC27367@rei.lan> (raw)
In-Reply-To: <20160608135528.GB27367@rei.lan>
Hi!
And I guess that the best solution is to pass the exit value to
do_exit(), that way we have only one function that calls the exit() in
the code called by the test library process.
What about:
diff --git a/lib/tst_test.c b/lib/tst_test.c
index f7485bd..6e6d417 100644
--- a/lib/tst_test.c
+++ b/lib/tst_test.c
@@ -64,7 +64,7 @@ char *const tst_ipc_envp[] = {ipc_path, NULL};
static char shm_path[1024];
-static void do_exit(void) __attribute__ ((noreturn));
+static void do_exit(int ret) __attribute__ ((noreturn));
static void setup_ipc(void)
{
@@ -237,7 +237,7 @@ void tst_vbrk_(const char *file, const int lineno, int ttype,
do_test_cleanup();
if (getpid() == lib_pid)
- do_exit();
+ do_exit(TTYPE_RESULT(ttype));
exit(TTYPE_RESULT(ttype));
}
@@ -443,10 +443,8 @@ static void parse_opts(int argc, char *argv[])
}
-static void do_exit(void)
+static void do_exit(int ret)
{
- int ret = 0;
-
printf("\nSummary:\n");
printf("passed %d\n", results->passed);
printf("failed %d\n", results->failed);
@@ -719,7 +717,7 @@ void tst_run_tcases(int argc, char *argv[], struct tst_test *self)
do_cleanup();
if (WIFEXITED(status) && WEXITSTATUS(status))
- exit(WEXITSTATUS(status));
+ do_exit(WEXITSTATUS(status));
if (WIFSIGNALED(status) && WTERMSIG(status) == SIGKILL) {
tst_res(TINFO, "If you are running on slow machine, "
@@ -730,5 +728,5 @@ void tst_run_tcases(int argc, char *argv[], struct tst_test *self)
if (WIFSIGNALED(status))
tst_brk(TBROK, "Test killed by %s!", tst_strsig(WTERMSIG(status)));
- do_exit();
+ do_exit(0);
}
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2016-06-08 14:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 11:58 [LTP] [PATCH v2] lib/tst_test.c: Run test in child process Cyril Hrubis
2016-06-08 8:17 ` Jan Stancek
2016-06-08 12:30 ` Cyril Hrubis
2016-06-08 12:59 ` Jan Stancek
2016-06-08 13:15 ` Cyril Hrubis
2016-06-08 13:36 ` Jan Stancek
2016-06-08 13:55 ` Cyril Hrubis
2016-06-08 14:06 ` Cyril Hrubis [this message]
2016-06-08 14:31 ` Jan Stancek
2016-06-08 14:32 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160608140635.GC27367@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox