From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] new ltp lib doesn't print actual error
Date: Mon, 20 Jun 2016 14:17:59 +0200 [thread overview]
Message-ID: <20160620121758.GB22157@rei.lan> (raw)
In-Reply-To: <57618B7B.9070402@oracle.com>
Hi!
> When running a test with the new LTP lib, noticed that if some error
> occurs in a library (tst_tmpdir.c), it'll print the same message:
>
> TMPDIR=/usr ./creat01
> tst_tmpdir.c:155: BROK: Non-NULL cleanup in newlib!
>
> but should be:
> TMPDIR=/usr ./creat01
> tst_tmpdir.c:155: BROK: tst_tmpdir: mkdtemp(/usr/creF5DhMS) failed: EACCES
>
>
> May be we should remove the strict check in tst_res.c? Otherwise we
> don't see the actual error.
Passing a cleanup callback from newlib testcase is always a mistake
because it's never executed. I would prefer keeping the check in the
library.
It does not matter in case of tmpdir_cleanup() since that function only
prints a warning message. What about removing the tmpdir_cleanup()
cleanup instead? It does not seem to be useful to me anyway.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2016-06-20 12:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 17:08 [LTP] new ltp lib doesn't print actual error Alexey Kodanev
2016-06-15 17:28 ` Jan Stancek
2016-06-16 8:46 ` Alexey Kodanev
2016-06-20 12:17 ` Cyril Hrubis [this message]
2016-06-20 15:58 ` Alexey Kodanev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160620121758.GB22157@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox