public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] network/perf_lan: remove the test
Date: Wed, 22 Jun 2016 16:45:16 +0200	[thread overview]
Message-ID: <20160622144516.GI13962@rei.lan> (raw)
In-Reply-To: <1465571138-28420-1-git-send-email-alexey.kodanev@oracle.com>

Hi!
> * Test does what 'ping -p' command can do (can be added to tcp_cmds/ping);
> * It needs cleanup/fixing and IPv6 version is disabled right now;
> * ck_packet() is wrongly setting data buffer pointer, assuming that
>   the sender added timestamp but it didn't. Actually timestamp was
>   removed in the packet sending code but not in the receiving one
>   (patch ef77253);
> * Also test always passes, even if packet data is not correct, because
>   ck_packet() always returns 0, so it doesn't really check packets.

The test really seems to be recreating in C what could be done with ping
albeit it seems to send count packets as fast as possible, as far as I
can tell it does someting equivalent to:

"ping -c $count -f -s $packetsize -p 00010203..."

Also looking closer the $count is wired to 1, so the -f does not have
any effect.

I guess that the ping01 covers more or less the same and adding more
functionality to it is much easier than fixing the mess called perf_lan.

In short, the removal is acked.

-- 
Cyril Hrubis
chrubis@suse.cz

  reply	other threads:[~2016-06-22 14:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-10 15:05 [LTP] [PATCH] network/perf_lan: remove the test Alexey Kodanev
2016-06-22 14:45 ` Cyril Hrubis [this message]
2016-06-23 11:28   ` Alexey Kodanev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160622144516.GI13962@rei.lan \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox