From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] lib: add [SAFE_]FILE_LINES_SCANF
Date: Mon, 18 Jul 2016 13:36:44 +0200 [thread overview]
Message-ID: <20160718113644.GA18221@rei.suse.cz> (raw)
In-Reply-To: <ae355058af800fd8fbc410b839ce25a128ab4339.1468492135.git.jstancek@redhat.com>
Hi!
> lib/tests/tst_safe_fileops.c | 40 +++++++++++++++++++++++++++++++++++
The last minor nitpick is that the lib/tests/ directory is full of
oldlib tests and this is a newlib test. It may be better to add this
file to the lib/newlib_tests/.
Anyway this version looks fine, acked.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2016-07-18 11:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-14 10:35 [LTP] [PATCH] lib: add [SAFE_]FILE_LINES_SCANF Jan Stancek
2016-07-18 11:36 ` Cyril Hrubis [this message]
2016-07-18 13:52 ` Jan Stancek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160718113644.GA18221@rei.suse.cz \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox