From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] madvise06: wait a bit after madvise() call
Date: Mon, 18 Jul 2016 16:03:19 +0200 [thread overview]
Message-ID: <20160718140319.GA19087@rei.suse.cz> (raw)
In-Reply-To: <8eb6f485a46b9d9fb62eec232bf7bcb2d4cf4215.1468848169.git.jstancek@redhat.com>
Hi!
> madvise_willneed() only schedules I/O and does not
> wait for completion, so there is possibility for this
> testcase to fail occasionally.
>
> This patch is introducing a small delay and checks the
> effect of madvise on more pages.
Looks good.
What is the reason for using more than one page? Does that increase the
likehood of triggering the issue?
Another idea may be to utilize bitflags from /proc/self/pagemap which
would be non-destructive way to get the present/swapped information.
Then we can do a short loop that polls these flags with much shorter
sleep, but the code would likely end up more complicated than this...
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2016-07-18 14:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-18 13:37 [LTP] [PATCH] madvise06: wait a bit after madvise() call Jan Stancek
2016-07-18 14:03 ` Cyril Hrubis [this message]
2016-07-18 14:22 ` Jan Stancek
2016-07-18 14:49 ` Cyril Hrubis
2016-07-19 5:58 ` Li Wang
2016-07-19 6:56 ` Jan Stancek
2016-07-19 8:57 ` Li Wang
2016-07-20 14:37 ` Jan Stancek
2016-07-21 5:33 ` Li Wang
2016-07-21 10:31 ` Chunyu Hu
2016-07-21 11:02 ` Li Wang
2016-07-21 14:23 ` Jan Stancek
2016-07-22 3:46 ` Li Wang
2016-07-22 6:59 ` Jan Stancek
2016-07-22 10:49 ` Chunyu Hu
2016-07-22 10:54 ` Chunyu Hu
2016-07-22 11:02 ` Jan Stancek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160718140319.GA19087@rei.suse.cz \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox