public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH V3 07/23] ptrace: Use int instead of enum __ptrace_request
Date: Tue, 26 Jul 2016 18:03:30 +0200	[thread overview]
Message-ID: <20160726160329.GD5868@rei> (raw)
In-Reply-To: <20160722042656.22346-7-raj.khem@gmail.com>

Hi!
> __ptrace_request is only available with glibc
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  testcases/kernel/syscalls/ptrace/ptrace03.c           | 2 +-
>  testcases/kernel/syscalls/ptrace/spawn_ptrace_child.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/testcases/kernel/syscalls/ptrace/ptrace03.c b/testcases/kernel/syscalls/ptrace/ptrace03.c
> index a4028fc..f326b83 100644
> --- a/testcases/kernel/syscalls/ptrace/ptrace03.c
> +++ b/testcases/kernel/syscalls/ptrace/ptrace03.c
> @@ -102,7 +102,7 @@ static pid_t unused_pid;
>  static pid_t zero_pid;
>  
>  struct test_case_t {
> -	enum __ptrace_request request;
> +	int request;
>  	pid_t *pid;
>  	int exp_errno;
>  } test_cases[] = {
> diff --git a/testcases/kernel/syscalls/ptrace/spawn_ptrace_child.h b/testcases/kernel/syscalls/ptrace/spawn_ptrace_child.h
> index ae538e9..83de9b4 100644
> --- a/testcases/kernel/syscalls/ptrace/spawn_ptrace_child.h
> +++ b/testcases/kernel/syscalls/ptrace/spawn_ptrace_child.h
> @@ -130,7 +130,7 @@ static char *strings[] = {
>  	SPT(KILL)
>  	SPT(SINGLESTEP)
>  };
> -static inline char *strptrace(enum __ptrace_request request)
> +static inline char *strptrace(int request)
>  {
>  	return strings[request];
>  }

The enum __ptrace_request is used to describe the function prototype in
the ptrace() manual page so one can argue that it's part of the official
API.

If I remeber right, it's missing in musl libc and the code in question
fails to compile.

CCing glibc ML and also man-pages ML to see if the type is used in
manual page intentionally or not.

-- 
Cyril Hrubis
chrubis@suse.cz

  reply	other threads:[~2016-07-26 16:03 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-22  4:26 [LTP] [PATCH V3 01/23] Add knob to control whether numa support should be checked Khem Raj
2016-07-22  4:26 ` [LTP] [PATCH V3 02/23] Add knob to control tirpc support Khem Raj
2016-07-26 14:35   ` Cyril Hrubis
2016-07-26 14:56     ` Khem Raj
2016-07-22  4:26 ` [LTP] [PATCH V3 03/23] Remove including error.h, its unused Khem Raj
2016-07-26 15:05   ` Cyril Hrubis
2016-07-22  4:26 ` [LTP] [PATCH V3 04/23] Remove unused __BEGIN_DECLS and __END_DECLS Khem Raj
2016-07-26 15:39   ` Cyril Hrubis
2016-07-22  4:26 ` [LTP] [PATCH V3 05/23] guard mallocopt() with __GLIBC__ Khem Raj
2016-07-26 15:44   ` Cyril Hrubis
2016-07-22  4:26 ` [LTP] [PATCH V3 06/23] Use unsigned int instead of uint Khem Raj
2016-07-26 15:51   ` Cyril Hrubis
2016-07-22  4:26 ` [LTP] [PATCH V3 07/23] ptrace: Use int instead of enum __ptrace_request Khem Raj
2016-07-26 16:03   ` Cyril Hrubis [this message]
2016-07-22  4:26 ` [LTP] [PATCH V3 08/23] rt_sigaction/rt_sigprocmark: Replace SA_NOMASK with SA_NODEFER Khem Raj
2016-07-27 10:14   ` Cyril Hrubis
2016-07-27 15:14     ` Khem Raj
2016-07-27 15:35       ` Cyril Hrubis
2016-07-22  4:26 ` [LTP] [PATCH V3 09/23] mc_gethost: Use unsigned char instead of u_char Khem Raj
2016-07-27 10:20   ` Cyril Hrubis
2016-07-22  4:26 ` [LTP] [PATCH V3 10/23] sysconf01: Use _SC_2_C_VERSION conditionally Khem Raj
2016-08-01 15:36   ` Cyril Hrubis
2016-07-22  4:26 ` [LTP] [PATCH V3 11/23] lapi: Use sig_t instead of sighandler_t Khem Raj
2016-07-27 10:22   ` Cyril Hrubis
2016-07-27 15:15     ` Khem Raj
2016-07-27 16:03       ` Cyril Hrubis
2016-07-22  4:26 ` [LTP] [PATCH V3 12/23] trace_shed: Adapt to glibc 2.24 removal of union wait type Khem Raj
2016-08-01 15:22   ` Cyril Hrubis
2016-07-22  4:26 ` [LTP] [PATCH V3 13/23] vma03: fix page size offset as per page size alignment Khem Raj
2016-07-27 13:45   ` Cyril Hrubis
2016-07-22  4:26 ` [LTP] [PATCH V3 14/23] shmat1: Cover GNU specific code under __USE_GNU Khem Raj
2016-07-27 14:17   ` Cyril Hrubis
2016-07-27 15:20     ` Khem Raj
2016-07-22  4:26 ` [LTP] [PATCH V3 15/23] Add periodic output for long time test Khem Raj
2016-07-27 14:37   ` Cyril Hrubis
2016-07-27 15:21     ` Tudor Florea
2016-07-27 15:33       ` Cyril Hrubis
2016-07-22  4:26 ` [LTP] [PATCH V3 16/23] Fix test_proc_kill hanging Khem Raj
2016-07-27 14:46   ` Cyril Hrubis
2016-07-22  4:26 ` [LTP] [PATCH V3 17/23] initialize recursive mutex in a portable way Khem Raj
2016-07-27 15:30   ` Cyril Hrubis
2016-07-22  4:26 ` [LTP] [PATCH V3 18/23] replace SIGCLD with SIGCHLD Khem Raj
2016-07-27 16:24   ` Cyril Hrubis
2016-07-22  4:26 ` [LTP] [PATCH V3 19/23] creat06: Include limits.h for PATH_MAX Khem Raj
2016-08-01 12:49   ` Cyril Hrubis
2016-07-22  4:26 ` [LTP] [PATCH V3 20/23] fcntl34: Replace pthread_yield() with sched_yield() Khem Raj
2016-08-01 12:57   ` Cyril Hrubis
2016-07-22  4:26 ` [LTP] [PATCH V3 21/23] rename 'sigset' var to avoid shadowing with libc symbol sigset Khem Raj
2016-08-01 14:19   ` Cyril Hrubis
2016-07-22  4:26 ` [LTP] [PATCH V3 22/23] pec: Replace obsoleted SA_ONESHOT with SA_RESETHAND Khem Raj
2016-08-01 14:30   ` Cyril Hrubis
2016-07-22  4:26 ` [LTP] [PATCH V3 23/23] shmem_test_04: Include sys/types.h for caddr_t Khem Raj
2016-08-01 14:34   ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160726160329.GD5868@rei \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox