From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] syscalls/fcntl34: Use -D_FILE_OFFSET_BITS=64 for all cases
Date: Mon, 15 Aug 2016 14:08:10 +0200 [thread overview]
Message-ID: <20160815120810.GC20680@rei.lan> (raw)
In-Reply-To: <1471021912-29886-1-git-send-email-yuriy.kolerov@synopsys.com>
Hi!
> This test uses OFD locks which are supported only by 64-bit ABI.
> Thus OFD locks must be used with flock64 structure for sure in this
> test. It is necessary because on some 32-bit targets (e.g. 32-bit
> uClibc) flock is not mapped to flock64 when _FILE_OFFSET_BITS is not
> set to 64. Thus fcntl34 and fcntl34_64 must be identical. It is an
> ugly but the easiest solution.
Indeed the test fails on 32bit platform without the
_FILE_OFFSET_BITS=64. But it fails correctly with EINVAL in this case
since the ioctl() in question is not implemented.
So better solution would be to try the ioctl() in the test setup and
report TCONF if we got EINVAL.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2016-08-15 12:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-12 17:11 [LTP] [PATCH] syscalls/fcntl34: Use -D_FILE_OFFSET_BITS=64 for all cases Yuriy Kolerov
2016-08-15 12:08 ` Cyril Hrubis [this message]
2016-08-16 9:46 ` Yuriy Kolerov
2016-08-16 10:02 ` Cyril Hrubis
2016-08-16 10:47 ` Yuriy Kolerov
2016-08-16 11:02 ` Peter Maydell
2016-08-16 11:31 ` Cyril Hrubis
2016-08-16 11:30 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160815120810.GC20680@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox