From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] syscalls/fcntl34: Use -D_FILE_OFFSET_BITS=64 for all cases
Date: Tue, 16 Aug 2016 13:31:48 +0200 [thread overview]
Message-ID: <20160816113148.GC24312@rei.lan> (raw)
In-Reply-To: <CAFEAcA9DiMn=YE25Jk_MoQYHa_B3FxcdLWycAjoxH8neyzEvMA@mail.gmail.com>
Hi!
> > Actually both glibc and uClibc use fcntl64 by default and usually
> > fail when you try to pass 32-bit flock structure to it when you
> > use OFD locks. Then fcntl64 fails in fcntl_setlk64 routing while
> > checking l_pid field.
>
> Given the cleverness glibc applies to flock(), it might be more
> useful for the LTP syscall tests to directly test the system calls
> avoiding the libc wrappers. That way you could know that you've
> definitely tested both flock and flock64 syscalls on platforms
> where they exist.
I guess that we should be testing both. As it stands now we do not test
the 32bit fcntl() at all.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2016-08-16 11:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-12 17:11 [LTP] [PATCH] syscalls/fcntl34: Use -D_FILE_OFFSET_BITS=64 for all cases Yuriy Kolerov
2016-08-15 12:08 ` Cyril Hrubis
2016-08-16 9:46 ` Yuriy Kolerov
2016-08-16 10:02 ` Cyril Hrubis
2016-08-16 10:47 ` Yuriy Kolerov
2016-08-16 11:02 ` Peter Maydell
2016-08-16 11:31 ` Cyril Hrubis [this message]
2016-08-16 11:30 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160816113148.GC24312@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox