public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] fcntl.2: F_OFD_XXX needs flock64
Date: Wed, 17 Aug 2016 15:34:06 +0200	[thread overview]
Message-ID: <20160817133406.GF10343@rei.lan> (raw)
In-Reply-To: <1471440855.3196.26.camel@poochiereds.net>

Hi!
> > You probably misunderstand what I was trying to say. If you look at the
> > > sources out there (for instance at https://codesearch.debian.net/) most
> > of it has fallback definitions for F_OFD_* constants included in its own
> > header files since these flags are relatively new. Not defining these
> > would not accomplish anything.
> > 
> > One option would be to define them to something invalid such as INT_MAX
> > so that it's rejected by kernel on runtime. But I do not think this is
> > very good idea either.
> > 
> 
> Yeah, not much we can do about people that define them on their own. If
> you do that, then you're basically saying "I know what I'm doing".
> 
> Still, I think it's worthwhile to do this in glibc since we _can_
> prevent this problem for folks who aren't doing that.

Ok.

Then this should be also paired with patch for the manual page that
explains that these locks are only available with the
_FILE_OFFSET_BITS=64.

-- 
Cyril Hrubis
chrubis@suse.cz

  reply	other threads:[~2016-08-17 13:34 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-16 11:55 [LTP] [PATCH] fcntl.2: F_OFD_XXX needs flock64 Cyril Hrubis
2016-08-16 14:34 ` Cyril Hrubis
2016-08-16 20:04 ` Michael Kerrisk
2016-08-16 23:41   ` Jeff Layton
2016-08-17  1:08     ` Michael Kerrisk
2016-08-17  8:10     ` Cyril Hrubis
2016-08-17 11:44       ` Jeff Layton
2016-08-17 11:53         ` Cyril Hrubis
2016-08-17 13:14           ` Jeff Layton
2016-08-17 13:19             ` Cyril Hrubis
2016-08-17 13:34               ` Jeff Layton
2016-08-17 13:34                 ` Cyril Hrubis [this message]
2016-08-17 19:44         ` Michael Kerrisk
2016-08-17  7:44   ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160817133406.GF10343@rei.lan \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox