From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cyril Hrubis Date: Tue, 6 Sep 2016 18:01:26 +0200 Subject: [LTP] [PATCH] memcg_process: cleanup the SHM segment In-Reply-To: <1472819042-25151-1-git-send-email-stanislav.kholmanskikh@oracle.com> References: <1472819042-25151-1-git-send-email-stanislav.kholmanskikh@oracle.com> Message-ID: <20160906160126.GA21090@rei.lan> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ltp@lists.linux.it Hi! > Let's mark the segment for removal right after we attach it. > This way memcg* test cases will no longer leave unused > segments after they finish. > > Signed-off-by: Stanislav Kholmanskikh > --- > .../controllers/memcg/functional/memcg_process.c | 9 ++++----- > 1 files changed, 4 insertions(+), 5 deletions(-) > > diff --git a/testcases/kernel/controllers/memcg/functional/memcg_process.c b/testcases/kernel/controllers/memcg/functional/memcg_process.c > index fbb76e2..e2c60de 100644 > --- a/testcases/kernel/controllers/memcg/functional/memcg_process.c > +++ b/testcases/kernel/controllers/memcg/functional/memcg_process.c > @@ -234,9 +234,6 @@ static void shm(void) > if (key == -1) > err(1, "ftok() failed"); > > - shmid = shmget(key, memsize, flag); > - if (shmid == -1) > - err(1, "shmget() failed"); > shmctl(shmid, IPC_RMID, NULL); ^ Shouldn't we remove this IPC_RMID as well? Otherwise it looks fine. -- Cyril Hrubis chrubis@suse.cz