From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/3] network/ping01: use ROD_SILENT and report test result
Date: Mon, 19 Sep 2016 12:31:14 +0200 [thread overview]
Message-ID: <20160919103113.GA7877@rei.lan> (raw)
In-Reply-To: <1473320058-13205-2-git-send-email-alexey.kodanev@oracle.com>
Hi!
> @@ -47,12 +46,10 @@ do_test()
> local ipaddr=$(tst_ipaddr rhost)
> for packetsize in $PACKETSIZES; do
> tst_resm TINFO "call $PING_CMD with packet size = $packetsize"
> - $PING_CMD -c $COUNT -s $packetsize $ipaddr > /dev/null 2>&1
> - if [ $? -ne 0 ]; then
> - tst_resm TFAIL "$PING_CMD -c $COUNT -s $packetsize $ipaddr"
> - return
> - fi
> + ROD_SILENT $PING_CMD -c $COUNT -s $packetsize $ipaddr
What about we use the EXPECT_PASS here? The ROD_SILENT would produce
TBROK instead of TFAIL in case of failure.
I know that EXPECT_PASS wouldn't exit the test on first failure, do we
really need that anyway? And it also wouldn't silence the ping output,
which shouldn't be so much of a problem since the $COUNT is small.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2016-09-19 10:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-08 7:34 [LTP] [PATCH 1/3] network/ping01: rename file and update runtest files Alexey Kodanev
2016-09-08 7:34 ` [LTP] [PATCH 2/3] network/ping01: use ROD_SILENT and report test result Alexey Kodanev
2016-09-19 10:31 ` Cyril Hrubis [this message]
2016-09-19 12:10 ` Alexey Kodanev
2016-09-19 12:13 ` Cyril Hrubis
2016-09-08 7:34 ` [LTP] [PATCH 3/3] network/ping02: add new flood ping test Alexey Kodanev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160919103113.GA7877@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox