[LTP] [PATCH 2/3] network/ping01: use ROD_SILENT and report test result

Cyril Hrubis
2016-09-19T12:13:28Z

Hi!
> Yes, $COUNT is small but we should multiply it by $PACKETSIZES. Even
> with '-q' there will be a lot of output.
> What about adding redirection to /dev/null and removing tst_resm() as below:
>
> -TST_TOTAL=1
> +TST_TOTAL=10
> TCID="ping01"
>
> . test_net.sh
> @@ -45,11 +45,8 @@ do_test()
> tst_resm TINFO "$PING_CMD with $PACKETSIZES ICMP packets"
> local ipaddr=$(tst_ipaddr rhost)
> for packetsize in $PACKETSIZES; do
> - tst_resm TINFO "call $PING_CMD with packet size =
> $packetsize"
> - ROD_SILENT $PING_CMD -c $COUNT -s $packetsize $ipaddr
> + EXPECT_PASS $PING_CMD -c $COUNT -s $packetsize $ipaddr
> \>/dev/null
> done
> -
> - tst_resm TPASS "$PING_CMD test completed"
> }

Looks good.

--
Cyril Hrubis
chrubis@suse.cz