[LTP] [PATCH 2/3] network/ping01: use ROD_SILENT and report test result

Cyril Hrubis
2016-09-19T10:31:14Z

Hi!
> @@ -47,12 +46,10 @@ do_test()
> local ipaddr=$(tst_ipaddr rhost)
> for packetsize in $PACKETSIZES; do
> tst_resm TINFO "call $PING_CMD with packet size = $packetsize"
> - $PING_CMD -c $COUNT -s $packetsize $ipaddr > /dev/null 2>&1
> - if [ $? -ne 0 ]; then
> - tst_resm TFAIL "$PING_CMD -c $COUNT -s $packetsize $ipaddr"
> - return
> - fi
> + ROD_SILENT $PING_CMD -c $COUNT -s $packetsize $ipaddr

What about we use the EXPECT_PASS here? The ROD_SILENT would produce
TBROK instead of TFAIL in case of failure.

I know that EXPECT_PASS wouldn't exit the test on first failure, do we
really need that anyway? And it also wouldn't silence the ping output,
which shouldn't be so much of a problem since the $COUNT is small.

--
Cyril Hrubis
chrubis@suse.cz