From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/3] network/ping01: use ROD_SILENT and report test result
Date: Mon, 19 Sep 2016 14:13:28 +0200 [thread overview]
Message-ID: <20160919121328.GC6220@rei.lan> (raw)
In-Reply-To: <57DFD5B9.6090800@oracle.com>
Hi!
> Yes, $COUNT is small but we should multiply it by $PACKETSIZES. Even
> with '-q' there will be a lot of output.
> What about adding redirection to /dev/null and removing tst_resm() as below:
>
> -TST_TOTAL=1
> +TST_TOTAL=10
> TCID="ping01"
>
> . test_net.sh
> @@ -45,11 +45,8 @@ do_test()
> tst_resm TINFO "$PING_CMD with $PACKETSIZES ICMP packets"
> local ipaddr=$(tst_ipaddr rhost)
> for packetsize in $PACKETSIZES; do
> - tst_resm TINFO "call $PING_CMD with packet size =
> $packetsize"
> - ROD_SILENT $PING_CMD -c $COUNT -s $packetsize $ipaddr
> + EXPECT_PASS $PING_CMD -c $COUNT -s $packetsize $ipaddr
> \>/dev/null
> done
> -
> - tst_resm TPASS "$PING_CMD test completed"
> }
Looks good.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2016-09-19 12:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-08 7:34 [LTP] [PATCH 1/3] network/ping01: rename file and update runtest files Alexey Kodanev
2016-09-08 7:34 ` [LTP] [PATCH 2/3] network/ping01: use ROD_SILENT and report test result Alexey Kodanev
2016-09-19 10:31 ` Cyril Hrubis
2016-09-19 12:10 ` Alexey Kodanev
2016-09-19 12:13 ` Cyril Hrubis [this message]
2016-09-08 7:34 ` [LTP] [PATCH 3/3] network/ping02: add new flood ping test Alexey Kodanev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160919121328.GC6220@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox