From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/2] writev: remove old tests for partially invalid iovec
Date: Wed, 5 Oct 2016 17:38:56 +0200 [thread overview]
Message-ID: <20161005153856.GD23476@rei.lan> (raw)
In-Reply-To: <aaac8a5d1c04de00152f0ab569d732323ab800ab.1475670993.git.jstancek@redhat.com>
Hi!
> - /* testcase# 3 */
> + /* TODO: remove this, partially invalid iovec is tested in writev07 */
> {(buf1 + CHUNK * 6), CHUNK},
> {(caddr_t) - 1, CHUNK},
> {(buf1 + CHUNK * 8), CHUNK},
Maybe it would be better to split this into five struct iovec structures
to avoid the magic constants in the code. Otherwise it's fine.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2016-10-05 15:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-05 12:36 [LTP] [PATCH 1/2] syscalls: new test writev07 Jan Stancek
2016-10-05 12:36 ` [LTP] [PATCH 2/2] writev: remove old tests for partially invalid iovec Jan Stancek
2016-10-05 15:38 ` Cyril Hrubis [this message]
2016-10-05 15:23 ` [LTP] [PATCH 1/2] syscalls: new test writev07 Cyril Hrubis
2016-10-05 16:21 ` Jan Stancek
2016-10-06 7:16 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161005153856.GD23476@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox