From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] [RFC] readahead02: Fix on Btrfs
Date: Thu, 6 Oct 2016 13:16:38 +0200 [thread overview]
Message-ID: <20161006111638.GB9711@rei> (raw)
In-Reply-To: <414326668.771913.1475747794724.JavaMail.zimbra@redhat.com>
Hi!
> > > If this patch goes through, then reading read_ahead_kb becomes
> > > useless:
> > > https://lkml.org/lkml/2016/7/25/308
> > >
> > > Perhaps, we should stop focusing on max size. We could change it to start
> > > with size of entire file, and for subsequent calls update file offset as
> > > max(MIN_SANE_READAHEAD, cache_increase_since_last_call), where
> > > MIN_SANE_READAHEAD
> > > would be some small arbitrary number. So there would be a guarantee
> > > it can eventually finish and any smaller readahead than that number would
> > > be considered a failure.
> >
> > Sounds reasonable. Will you prepare a patch or should i work on it?
>
> I want to finish writev patches first (very visible 4.8 syscall failure,
> if I don't count scenario in this thread). If you need this ASAP then
> go ahead, otherwise I can pick it up later.
No rush, this test wasn't working on Btrfs for quite some time.
--
Cyril Hrubis
chrubis@suse.cz
prev parent reply other threads:[~2016-10-06 11:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-06 8:17 [LTP] [PATCH] [RFC] readahead02: Fix on Btrfs Cyril Hrubis
2016-10-06 9:09 ` Jan Stancek
2016-10-06 9:32 ` Cyril Hrubis
2016-10-06 9:56 ` Jan Stancek
2016-10-06 11:16 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161006111638.GB9711@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox