[LTP] new shell library

Cyril Hrubis
2016-10-04T09:35:49Z

Hi!
> > What about we do it as:
> >
> > TST_ID="du01"
> > TST_CNT=23
> > TST_SETUP=setup
> > TST_CLEANUP=cleanup
> > TST_TESTFUNC=du_test
> > TST_NEEDS_TMPDIR=1
> > TST_NEEDS_CMDS="dd du stat"
> > . tst_test.sh
> >
> > # the actuall test code
> >
> > tst_run
>
> OK, giving all uniform names (TST_) and adding setup/cleanup/testfunc
> makes it more clear.
>
> What role does ". tst_test.sh" have in example above? Does it
> have to come after you define all variables? If so, what does
> it do?
>
> If we have tst_run, then it seems that could do all necessary
> checks and setup and we could include tst_test.sh at any point.

I somehow find it more clear to define all the variables that the
library script uses before we source it. IMHO that is better than having
them scattered all around the script, at this point both the old test.sh
and tst_test.sh scripts enforce that by doing sanity checks on the
variables when the library script is sourced.

Are any advantages for doing the sanity checks in the tst_run function?