public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/3] syscalls/umask01: Cleanup && Convert to new API
Date: Mon, 31 Oct 2016 12:26:02 +0100	[thread overview]
Message-ID: <20161031112602.GG30590@rei.lan> (raw)
In-Reply-To: <1477882478-30693-1-git-send-email-fenggw-fnst@cn.fujitsu.com>

Hi!
I guess that this test should be just removed since umask() cannot fail
at all.

To cite the manual page:

...

RETURN VALUE
       This system call always succeeds and the previous value of the
       mask is returned.

...


-- 
Cyril Hrubis
chrubis@suse.cz

      parent reply	other threads:[~2016-10-31 11:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-31  2:54 [LTP] [PATCH 1/3] syscalls/umask01: Cleanup && Convert to new API Guangwen Feng
2016-10-31  2:54 ` [LTP] [PATCH 2/3] syscalls/umask02: " Guangwen Feng
2016-10-31 11:35   ` Cyril Hrubis
2016-10-31  2:54 ` [LTP] [PATCH 3/3] syscalls/umask03: " Guangwen Feng
2016-10-31 11:40   ` Cyril Hrubis
2016-11-01  4:26     ` Guangwen Feng
2016-11-01 15:05       ` Cyril Hrubis
2016-11-02  2:42         ` Guangwen Feng
2016-11-02  7:14           ` [LTP] [PATCH v2] syscalls/umask01: Cleanup && Use the new API && Rename Guangwen Feng
2016-11-02 11:13             ` Cyril Hrubis
2016-10-31 11:26 ` Cyril Hrubis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161031112602.GG30590@rei.lan \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox