From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] containers/netns/netns_sysfs.sh: add kernel version check
Date: Mon, 31 Oct 2016 15:36:45 +0100 [thread overview]
Message-ID: <20161031143644.GA13468@rei.lan> (raw)
In-Reply-To: <d15b075f-b777-c6fe-8861-74d5a30a3305@redhat.com>
Hi!
> > where the modifiers would stand for:
> >
> > n newer
> > nq newer or equal
> > o older
> > oq older or equal
>
> If you're going to use letters for this, I suggest re-using what the
> 'test' a.k.a. '[' command has: -eq, -lt, -ge, -ne, etc.
>
> If multiple options (like in your example) are supported, re-using the
> logic from 'test' could also be a good idea: -a (and), -o (or), although
> shell-based && or || might be more obvious.
>
> if tst_kvercmp -ge "2.6.35" -a -lt "3.8"; then ...
>
> if tst_kvercmp -ge "2.6.35" && tst_kvercmp -lt "3.8"; then ...
Sounds good. I will look into this.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2016-10-31 14:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 8:01 [LTP] [PATCH] containers/netns/netns_sysfs.sh: add kernel version check Guangwen Feng
2016-10-25 7:24 ` Guangwen Feng
2016-10-26 18:17 ` Jiri Jaburek
2016-10-27 7:55 ` Guangwen Feng
2016-10-31 9:28 ` Cyril Hrubis
2016-10-31 14:05 ` Jiri Jaburek
2016-10-31 14:36 ` Cyril Hrubis [this message]
2016-11-01 14:30 ` Cyril Hrubis
2016-10-31 9:31 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161031143644.GA13468@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox