From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 3/3] syscalls/umask03: Cleanup && Convert to new API
Date: Tue, 1 Nov 2016 16:05:08 +0100 [thread overview]
Message-ID: <20161101150508.GA5787@rei.lan> (raw)
In-Reply-To: <58181967.9070700@cn.fujitsu.com>
Hi!
> > Hmm, so this test is just the same as umask02 but tries to create the
> > file as well.
> >
> > What about we remove umask01.c and umask02.c and rename umask03.c to
> > umask01.c?
> >
> > It's not like umask01.c or umask02.c adds any more value since umask03.c
> > is superset of these.
> >
>
> I think it's a little bit different between umask02 and umask03, manual page
> says that umask(2) returns the previous value of the mask, and this is only
> checked in umask02.
>
> So what about we just remove umask01.c and rename umask02.c and umask03.c to
> umask01.c and umask02.c?
Hmm, right, the umask03 is not checking the return value. But still,
it's trivial enough to both check the return value and to try to create
the file in one test. There is no real need to have two when thing could
be easily done in just one.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2016-11-01 15:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-31 2:54 [LTP] [PATCH 1/3] syscalls/umask01: Cleanup && Convert to new API Guangwen Feng
2016-10-31 2:54 ` [LTP] [PATCH 2/3] syscalls/umask02: " Guangwen Feng
2016-10-31 11:35 ` Cyril Hrubis
2016-10-31 2:54 ` [LTP] [PATCH 3/3] syscalls/umask03: " Guangwen Feng
2016-10-31 11:40 ` Cyril Hrubis
2016-11-01 4:26 ` Guangwen Feng
2016-11-01 15:05 ` Cyril Hrubis [this message]
2016-11-02 2:42 ` Guangwen Feng
2016-11-02 7:14 ` [LTP] [PATCH v2] syscalls/umask01: Cleanup && Use the new API && Rename Guangwen Feng
2016-11-02 11:13 ` Cyril Hrubis
2016-10-31 11:26 ` [LTP] [PATCH 1/3] syscalls/umask01: Cleanup && Convert to new API Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161101150508.GA5787@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox