From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2] syscalls/access04: Convert to new API && Rename
Date: Wed, 2 Nov 2016 14:39:46 +0100 [thread overview]
Message-ID: <20161102133946.GA23975@rei> (raw)
In-Reply-To: <1478079766-4457-1-git-send-email-fenggw-fnst@cn.fujitsu.com>
Hi!
> +static void cleanup(void)
> +{
> + if (mount_flag && tst_umount(MNT_POINT) < 0) {
> + tst_brk(TBROK | TERRNO, "umount device:%s failed",
> + tst_device->dev);
> + }
> +}
You must not call tst_brk() from the test cleanup, that would cause
infinite loop and segfault. You should call tst_res(TWARN, "...");
instead.
And the tst_umount() calls tst_res(TWARN, "..."); already so we can just
do:
...
if (mount_flag)
tst_umount(MNT_POINT);
...
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2016-11-02 13:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-01 9:18 [LTP] [PATCH] syscalls/access04: Convert to new API && Rename Guangwen Feng
2016-11-02 9:42 ` [LTP] [PATCH v2] " Guangwen Feng
2016-11-02 13:39 ` Cyril Hrubis [this message]
2016-11-03 4:05 ` [LTP] [PATCH v3] " Guangwen Feng
2016-11-03 4:10 ` Guangwen Feng
2016-11-03 4:17 ` Guangwen Feng
2016-11-16 2:41 ` [LTP] [PATCH v4] " Guangwen Feng
2016-12-12 16:51 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161102133946.GA23975@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox