From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/3] socketcall: TCONF instead of TFAIL when user is not root
Date: Wed, 2 Nov 2016 15:46:11 +0100 [thread overview]
Message-ID: <20161102144611.GB28344@rei.lan> (raw)
In-Reply-To: <1478087824-31577-3-git-send-email-dejan.jovicevic@rt-rk.com>
Hi!
> sockatcall01 uses certain protocols that require super user
> privileges.
Right, the RAW socket needs root. You should have included that in the
commit message from the start. Pushed with better commit message, thanks.
Also it took me while to realize that the syscall is not implemented on
x86_64 and that the test returns PASS wrongly instead of CONF. I have
fixed that in another patch as well.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2016-11-02 14:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-02 11:57 [LTP] [PATCH 0/3] Additional checks for sched_xxx, socketcall01, inotify06 Dejan Jovicevic
2016-11-02 11:57 ` [LTP] [PATCH 1/3] sched_xxx: TCONF instead of TFAIL if user is not root Dejan Jovicevic
2016-11-02 14:07 ` Cyril Hrubis
2016-11-02 11:57 ` [LTP] [PATCH 2/3] socketcall: TCONF instead of TFAIL when " Dejan Jovicevic
2016-11-02 14:46 ` Cyril Hrubis [this message]
2016-11-02 11:57 ` [LTP] [PATCH 3/3] inotify06: kernel version check Dejan Jovicevic
2016-11-02 14:48 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161102144611.GB28344@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox