From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v3 3/5] llistxattr: improved code readability and
Date: Wed, 2 Nov 2016 16:44:22 +0100 [thread overview]
Message-ID: <20161102154422.GF28344@rei.lan> (raw)
In-Reply-To: <1478084391-30192-4-git-send-email-dejan.jovicevic@rt-rk.com>
Hi!
> static void verify_llistxattr(unsigned int n)
> @@ -59,7 +57,7 @@ static void verify_llistxattr(unsigned int n)
>
> TEST(llistxattr(name, NULL, 0));
> if (TEST_RETURN == -1) {
> - tst_res(TFAIL | TERRNO, "llistxattr() failed");
> + tst_res(TFAIL | TTERRNO, "llistxattr() failed");
The TERRNO -> TTERRNO has been fixed by:
https://github.com/linux-test-project/ltp/commit/00b4cdeed78d43e3f9dca769ef444f68cbb681c1
Please rebase this patch.
> return;
> }
>
> @@ -71,8 +69,6 @@ static void verify_llistxattr(unsigned int n)
>
> static void setup(void)
> {
> - int ret;
> -
This removal should have been part of the prevous patch, right?
> SAFE_TOUCH(filename[0], 0644, NULL);
>
> SAFE_TOUCH(filename[1], 0644, NULL);
Otherwise it looks good.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2016-11-02 15:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-02 10:59 [LTP] [PATCH v3 0/5] Listxattr related calls: new tests and testcase Dejan Jovicevic
2016-11-02 10:59 ` [LTP] [PATCH v3 1/5] safe_macros: add safe_setxattr(), Dejan Jovicevic
2016-11-02 15:37 ` Cyril Hrubis
2016-11-02 10:59 ` [LTP] [PATCH v3 2/5] llistxattr: moved to using safe macros Dejan Jovicevic
2016-11-02 15:38 ` Cyril Hrubis
2016-11-02 10:59 ` [LTP] [PATCH v3 3/5] llistxattr: improved code readability and Dejan Jovicevic
2016-11-02 15:44 ` Cyril Hrubis [this message]
2016-11-02 10:59 ` [LTP] [PATCH v3 4/5] llistxattr: new testcase for long path name Dejan Jovicevic
2016-11-02 15:47 ` Cyril Hrubis
2016-11-02 10:59 ` [LTP] [PATCH v3 5/5] flistxattr and listxattr: added tests Dejan Jovicevic
2016-11-02 16:13 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161102154422.GF28344@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox