[LTP] [PATCH v3 4/5] llistxattr: new testcase for long path name

Cyril Hrubis
2016-11-02T15:47:31Z

> +char longpathname[PATH_MAX + 2];

Should be static char.

> static struct test_case {
> const char *path;
> size_t size;
> @@ -54,7 +58,8 @@ static struct test_case {
> } tc[] = {
> {SYMLINK, 1, ERANGE},
> {"", 20, ENOENT},
> - {(char *)-1, 20, EFAULT}
> + {(char *)-1, 20, EFAULT},
> + {longpathname, 20, ENAMETOOLONG}
> };
>
> static void verify_llistxattr(unsigned int n)
> @@ -85,6 +90,8 @@ static void setup(void)
> SAFE_SYMLINK(TESTFILE, SYMLINK);
>
> SAFE_LSETXATTR(SYMLINK, SECURITY_KEY, VALUE, VALUE_SIZE, XATTR_CREATE);
> +
> + memset(&longpathname, 'a', sizeof(longpathname) - 1);

No need for the & here (in C array is a pointer to a first member and
&array == array).

Otherwise it's fine.

--
Cyril Hrubis
chrubis@suse.cz