[LTP] [PATCH v3 3/5] llistxattr: improved code readability and

Cyril Hrubis
2016-11-02T15:44:22Z

Hi!
> static void verify_llistxattr(unsigned int n)
> @@ -59,7 +57,7 @@ static void verify_llistxattr(unsigned int n)
>
> TEST(llistxattr(name, NULL, 0));
> if (TEST_RETURN == -1) {
> - tst_res(TFAIL | TERRNO, "llistxattr() failed");
> + tst_res(TFAIL | TTERRNO, "llistxattr() failed");

The TERRNO -> TTERRNO has been fixed by:

https://github.com/linux-test-project/ltp/commit/00b4cdeed78d43e3f9dca769ef444f68cbb681c1

Please rebase this patch.

> return;
> }
>
> @@ -71,8 +69,6 @@ static void verify_llistxattr(unsigned int n)
>
> static void setup(void)
> {
> - int ret;
> -

This removal should have been part of the prevous patch, right?

> SAFE_TOUCH(filename[0], 0644, NULL);
>
> SAFE_TOUCH(filename[1], 0644, NULL);

Otherwise it looks good.

--
Cyril Hrubis
chrubis@suse.cz