From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] memcg_control_test.sh:incorrect test result and a pipe issue
Date: Mon, 21 Nov 2016 12:39:03 +0100 [thread overview]
Message-ID: <20161121113902.GA25334@rei.lan> (raw)
In-Reply-To: <582D7289.6090303@oracle.com>
Hi!
> >> Moreover I was looking at the test recently and I would say that the
> >> best solution would be to remove it completely, since the same function
> >> should be covered by the memcg functional testcases. So the best bet
> >> here would be to check that it's covered by functional tests, if not add
> >> missing pieces to functional tests and get rid of this mess.
> > Ok,I will also check the functional test.
> I think this testcase can be covered by memcg_use_hierarchy in
> functional testcases.
> Maybe we can add a sub case in memcg_use_hierarchy test that check the
> parent limit for memsw.limit_in_bytes.
Both sounds good to me.
--
Cyril Hrubis
chrubis@suse.cz
prev parent reply other threads:[~2016-11-21 11:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-03 9:42 [LTP] [PATCH] memcg_control_test.sh:incorrect test result and a pipe issue shuang.qiu
2016-11-03 11:00 ` Cyril Hrubis
2016-11-03 14:08 ` Shuang Qiu
2016-11-17 9:04 ` Shuang Qiu
2016-11-21 11:39 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161121113902.GA25334@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox