From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/2] SAFE_MACROS: Add SAFE_SETPRIORITY() && Drop redundant space
Date: Tue, 22 Nov 2016 09:09:44 +0100 [thread overview]
Message-ID: <20161122080944.GE5620@rei.lan> (raw)
In-Reply-To: <1479375382-28964-1-git-send-email-fenggw-fnst@cn.fujitsu.com>
Hi!
I would rather see the whitespace cleanup in a separate patch. It's
harder to track what changes were done in a patch if it combines
unrelated changes.
And also this is 1/2, shouldn't there be a second patch that uses this?
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2016-11-22 8:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-17 9:36 [LTP] [PATCH 1/2] SAFE_MACROS: Add SAFE_SETPRIORITY() && Drop redundant space Guangwen Feng
2016-11-22 8:09 ` Cyril Hrubis [this message]
2016-11-22 9:42 ` Guangwen Feng
2016-11-22 10:22 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161122080944.GE5620@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox