From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v3 2/2] testcases/clock_nanosleep01: convert to use new test library API
Date: Mon, 28 Nov 2016 10:32:36 +0100 [thread overview]
Message-ID: <20161128093236.GD32359@rei.lan> (raw)
In-Reply-To: <20161125090522.njhmnswdk4sm676b@dell5510>
Hi!
> > Otherwise this version looks very good. Just keep in mind to keep the
> > lines under 80 characters.
> Right! I'm sorry about being relaxed on this so far.
> Just a question about strings: kernel formatting style [1] says about it:
> > However, never break user-visible strings such as
> > printk messages, because that breaks the ability to grep for them.
> And indeed my using plugin forcing kernel coding style [2] doesn't complain on strings
> So I hope string long up to 90 characters are still ok.
As far as I can tell we do not have any hard rules about this in LTP,
some code splits up the strings, some does not. I personally am trying
to keep things as short as possible while including all important bits
and I'm also avoiding unnecessary levels of indentation which keeps
things under 80 chars most of the time. I tend to split the string if
the line goes too long, which seems to be more or less about 130 chars.
--
Cyril Hrubis
chrubis@suse.cz
prev parent reply other threads:[~2016-11-28 9:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-24 16:01 [LTP] [PATCH v3 1/2] lib: move create_sig_proc() into newlib Petr Vorel
2016-11-24 16:01 ` [LTP] [PATCH v3 2/2] testcases/clock_nanosleep01: convert to use new test library API Petr Vorel
2016-11-24 16:48 ` Cyril Hrubis
2016-11-25 9:05 ` Petr Vorel
2016-11-28 9:32 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161128093236.GD32359@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox