From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 5/5] syscalls/setpriority01: Use new user id to avoid messing system environment
Date: Tue, 6 Dec 2016 11:34:36 +0100 [thread overview]
Message-ID: <20161206103436.GC17241@rei.lan> (raw)
In-Reply-To: <5846928B.2010805@cn.fujitsu.com>
Hi!
> > Hmm, why do we run the actuall testcase in the child here? That
> > complicates the whole test far more than it should have.
> >
> > We can instead just run pause() in the child and run the setpriority()
> > call in the parent with right pid/group/uid. Or did I miss something?
> >
>
> Sorry, if we do the actual test in the parent, we have to do the process
> synchronization, because parent needs child to be ready (prctl, setuid...)
> and after every test, child's pause() needs to be waken up by parent, so
> I feel it's more complicated by comparison...
Since we have the checkpoint synchronization in the test library this is
just a matter of calling TST_CHECKPOINT_WAIT() in the parent and
TST_CHECKPOINT_WAKE_AND_WAIT() in the child then finally
TST_CHECKPOINT_WAKE() in the parent.
--
Cyril Hrubis
chrubis@suse.cz
prev parent reply other threads:[~2016-12-06 10:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-30 12:12 [LTP] [PATCH 1/5] Cleanup && Drop redundant space in safe macros Guangwen Feng
2016-11-30 12:12 ` [LTP] [PATCH 2/5] SAFE_MACROS: Add SAFE_SETPRIORITY() Guangwen Feng
2016-11-30 12:12 ` [LTP] [PATCH 3/5] SAFE_MACROS: Add SAFE_SYSTEM() Guangwen Feng
2016-12-05 14:33 ` Cyril Hrubis
2016-12-06 10:02 ` Guangwen Feng
2016-11-30 12:12 ` [LTP] [PATCH 4/5] SAFE_MACROS: Add SAFE_PRCTL() Guangwen Feng
2016-12-05 14:40 ` Cyril Hrubis
2016-12-15 10:17 ` Guangwen Feng
2016-12-15 10:43 ` Cyril Hrubis
2016-12-15 10:49 ` [LTP] [PATCH v2 1/4] Cleanup && Drop redundant space in safe macros Guangwen Feng
2016-12-15 10:49 ` [LTP] [PATCH v2 2/4] SAFE_MACROS: Add SAFE_SETPRIORITY() Guangwen Feng
2016-12-15 10:49 ` [LTP] [PATCH v2 3/4] SAFE_MACROS: Add SAFE_PRCTL() Guangwen Feng
2016-12-15 10:49 ` [LTP] [PATCH v2 4/4] syscalls/setpriority01: Use new user id to avoid messing system environment Guangwen Feng
2017-01-04 12:13 ` Cyril Hrubis
2016-11-30 12:12 ` [LTP] [PATCH 5/5] " Guangwen Feng
2016-12-05 14:45 ` Cyril Hrubis
2016-12-06 10:27 ` Guangwen Feng
2016-12-06 10:34 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161206103436.GC17241@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox