[LTP] Invoking networking tests

[LTP] Invoking networking tests

[Petr Vorel]

Hi Alexey,

we're going to run LTP networking tests to against openSUSE and SUSE. Is there anything
you'd like to change on invoking these tests? Anything deprecated?

I see that scripts are run by ltp-pan (via. testscripts/network.sh wrapper), which is I
suppose standard way how to run any test in LTP (as it is in runltp and half of
testscripts/*.sh scripts).

How about testcases/lib/test_net.sh and testcases/lib/test.sh scripts? Not deprecated?

BTW: what is the purpose of testscripts/*.sh scripts, why it isn't everything integrated
into runltp?

Kind regards,
Petr

PS: sorry for duplicate mail, now sent with correct LTP mailing list address.

[LTP] Invoking networking tests

[Alexey Kodanev]

Hi Petr,

On 12/07/2016 05:18 PM, Petr Vorel wrote:
> Hi Alexey,
>
> we're going to run LTP networking tests to against openSUSE and SUSE. Is there anything
> you'd like to change on invoking these tests? Anything deprecated?

You can invoke network test as other LTP tests, just make sure you 
provided all
the necessary environment variables, all of them have default values, so 
youneed to
make sure they were set appropriately according to your environment.

Please also see the recent patch:
5f8ca6c ("network: test_net.sh: allow to run network tests on a single 
machine")

And any improvements are always welcome.

> I see that scripts are run by ltp-pan (via. testscripts/network.sh wrapper), which is I
> suppose standard way how to run any test in LTP (as it is in runltp and half of
> testscripts/*.sh scripts).
> How about testcases/lib/test_net.sh and testcases/lib/test.sh scripts? Not deprecated?

Not deprecated, i.e. if you encounter that a shell test not using either 
of these two,
it's quite outdated and needs to be converted to the newer library.

> BTW: what is the purpose of testscripts/*.sh scripts, why it isn't everything integrated
> into runltp?

Just a wrapper script for ltp-pan, provides convenient options to run 
network tests.
Some time ago network.sh used to have more functionality, like default 
values for
network environment variables, but now they all have moved to 
test_net.sh so we
don't depend on this script anymore.

Best regards,
Alexey

[LTP] Invoking networking tests

[Petr Vorel]

Hi Alexey,

thanks for info!

> Please also see the recent patch:
> 5f8ca6c ("network: test_net.sh: allow to run network tests on a single
> machine")
Noticed, I was waiting for pushing it to master :-). Looks interesting, I'll give it a try.

Can it be "dangerous" to run tests "natively", i.e. without ltp-pan? It'd be run by
automation (no cancel ctrl+c), so cleanup children is unlike. Or is it also for cleanup
when some test misbehave and it's being killed by kernel?


Kind regards,
Petr

[LTP] Invoking networking tests

[Alexey Kodanev]

Hi Petr,

On 12/08/2016 08:32 PM, Petr Vorel wrote:
> Hi Alexey,
>
> thanks for info!
>
>> Please also see the recent patch:
>> 5f8ca6c ("network: test_net.sh: allow to run network tests on a single
>> machine")
> Noticed, I was waiting for pushing it to master :-). Looks interesting, I'll give it a try.
>
> Can it be "dangerous" to run tests "natively", i.e. without ltp-pan? It'd be run by
> automation (no cancel ctrl+c), so cleanup children is unlike.

I think it depends on automation and how far it controls started process.

Besides, converted to latest LTP API tests much safer in terms of per 
test lockups because
they have a test timeout there. As far as I know there is no such 
feature in new shell library
yet (tst_test.sh). It seems that it would be a good thing to have a 
timeout option in tst_rod() too.

Thanks,
Alexey

> Or is it also for cleanup
> when some test misbehave and it's being killed by kernel?
>
>
> Kind regards,
> Petr

[LTP] Invoking networking tests

[Cyril Hrubis]

Hi!
> As far as I know there is no such feature in new shell library yet
> (tst_test.sh).

I will try to implement this until the next LTP release.

> It seems that it would be a good thing to have a timeout option in
> tst_rod() too.

That may be a good idea as well. We could fork() and watch for a timeout
in the tst_rod.c quite easily.

-- 
Cyril Hrubis
chrubis@suse.cz

[LTP] Invoking networking tests

[Cyril Hrubis]

Hi!
> I will try to implement this until the next LTP release.

Just to be clear "next" means the one after the already planned release
for January 2017.

-- 
Cyril Hrubis
chrubis@suse.cz

[LTP] Invoking networking tests

[Cyril Hrubis]

Hi!
> How about testcases/lib/test_net.sh and testcases/lib/test.sh scripts? Not deprecated?
> 
> BTW: what is the purpose of testscripts/*.sh scripts, why it isn't everything integrated
> into runltp?

The runltp script is big and hairy ball of shell code. It has too many
parameters already etc. Hence I would not like adding more code there.
Maybe we should clean it up or create runltp2 later and possibly include
the network bits as well.

And the testscripts/ directory contains mostly poorly maintained or
unmaintained scripts (minus the network.sh script). Some of these should
be cleaned and moved to testcases/ some may be removed. I would like to
get rid of the directory eventually.

-- 
Cyril Hrubis
chrubis@suse.cz