From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v3 1/4] syscalls/ipc: add newipc library for new API
Date: Wed, 14 Dec 2016 09:23:15 +0100 [thread overview]
Message-ID: <20161214082315.GA16198@rei.lan> (raw)
In-Reply-To: <20161213135233.GB750@rei.lan>
Hi!
> I've just found that this whole Makefile has been broken for ages and
> that the old library was build only by the inclusion of the Makefile.inc
> in the test directories, I wonder why this wasn't breaking parallel
> build at all. The whole reason is that MAKE_DEPS is ignored when
> MAKE_TARGETS is empty so the $(LIB) targets are not rebuild and removing
> the $(LIBDIR) from FILTER_OUT_DIRS is not solution either since that
> will break parallel build for sure.
>
> I will do something about this. One solution may be to set the
> MAKE_TARGETS to some phony target if it's empty. Let's see if I can
> figure out something better.
And, after a bit of research, I've realized, that without introducing
larger changes in the build system the only reasonable way how to build
a library is by using the Makefile.inc in all test subdirectories that
use it. That works since the make in subdirectories is executed in a
shell loop, which means that we will never end up building the same
library at the same time from several subdirectories.
So the correct way how to fix this issue is to add the libnewipc to the
FILTER_OUT_DIRS and create Makefile2.inc similar to Makefile.inc. I will
change the first patch to do exactly that and push the patchset.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2016-12-14 8:23 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 7:18 [LTP] [PATCH 1/4] ipc/lib: add header files for new API Xiao Yang
2016-11-23 7:18 ` [LTP] [PATCH 2/4] ipc/msgget01.c: cleanup && convert to " Xiao Yang
2016-11-23 14:05 ` Cyril Hrubis
2016-11-23 7:18 ` [LTP] [PATCH 3/4] ipc/msgget02.c: reconstruct " Xiao Yang
2016-11-23 14:13 ` Cyril Hrubis
2016-11-23 7:18 ` [LTP] [PATCH 4/4] ipc/msgget03.c: cleanup " Xiao Yang
2016-11-23 14:42 ` Cyril Hrubis
2016-11-23 13:55 ` [LTP] [PATCH 1/4] ipc/lib: add header files for " Cyril Hrubis
2016-12-07 5:16 ` [LTP] [PATCH v2 1/5] tst_test.h: move test result description to tst_res.h Xiao Yang
2016-12-07 5:16 ` [LTP] [PATCH v2 2/5] syscalls/ipc: add newipc library for new API Xiao Yang
2016-12-12 14:58 ` Cyril Hrubis
2016-12-12 15:10 ` Cyril Hrubis
2016-12-07 5:16 ` [LTP] [PATCH v2 3/5] ipc/msgget01.c: cleanup && convert to " Xiao Yang
2016-12-12 15:07 ` Cyril Hrubis
2016-12-07 5:16 ` [LTP] [PATCH v2 4/5] ipc/msgget02.c: reconstruct " Xiao Yang
2016-12-12 16:17 ` Cyril Hrubis
2016-12-07 5:16 ` [LTP] [PATCH v2 5/5] ipc/msgget03.c: cleanup " Xiao Yang
2016-12-12 16:24 ` Cyril Hrubis
2016-12-12 14:28 ` [LTP] [PATCH v2 1/5] tst_test.h: move test result description to tst_res.h Cyril Hrubis
2016-12-13 7:39 ` [LTP] [PATCH v3 1/4] syscalls/ipc: add newipc library for new API Xiao Yang
2016-12-13 7:39 ` [LTP] [PATCH v3 2/4] ipc/msgget01.c: cleanup && convert to " Xiao Yang
2016-12-13 7:39 ` [LTP] [PATCH v3 3/4] ipc/msgget02.c: reconstruct " Xiao Yang
2016-12-13 7:39 ` [LTP] [PATCH v3 4/4] ipc/msgget03.c: cleanup " Xiao Yang
2016-12-13 13:52 ` [LTP] [PATCH v3 1/4] syscalls/ipc: add newipc library for " Cyril Hrubis
2016-12-14 8:23 ` Cyril Hrubis [this message]
2016-12-14 9:19 ` Cyril Hrubis
2016-12-14 9:42 ` Xiao Yang
2016-12-13 7:46 ` [LTP] [PATCH v2 1/5] tst_test.h: move test result description to tst_res.h Xiao Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161214082315.GA16198@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox