From: Han Ning <ningx.han@intel.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH ltp] su01: do pre-checking to avoid annoying warnings
Date: Fri, 16 Dec 2016 08:31:07 +0800 [thread overview]
Message-ID: <20161216003107.GA16352@ninghanx> (raw)
In-Reply-To: <20161215121237.GC29787@rei.suse.cz>
On Thu, Dec 15, 2016 at 01:12:37PM +0100, Cyril Hrubis wrote:
> Hi!
> > - userdel $TEST_USER1
> > + getent passwd $TEST_USER1 && userdel $TEST_USER1
>
> Shouldn't we redirect the output from getent to /dev/null here?
Yes, we should. I'll send another patch for this.
>
> Otherwise it looks fine.
>
> --
> Cyril Hrubis
> chrubis@suse.cz
next prev parent reply other threads:[~2016-12-16 0:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-12 0:56 [LTP] [PATCH ltp] su01: do pre-checking to avoid annoying warnings Ning, Han
2016-12-15 12:12 ` Cyril Hrubis
2016-12-16 0:31 ` Han Ning [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-12-02 3:03 Han, NingX
2016-12-02 7:45 ` Petr Vorel
2016-12-05 0:56 ` Han Ning
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161216003107.GA16352@ninghanx \
--to=ningx.han@intel.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox