From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 4/4] syscalls/setpriority01: Use new user id to avoid messing system environment
Date: Wed, 4 Jan 2017 13:13:33 +0100 [thread overview]
Message-ID: <20170104121333.GA7680@rei.lan> (raw)
In-Reply-To: <1481798997-2320-4-git-send-email-fenggw-fnst@cn.fujitsu.com>
Hi!
> setpriority(PRIO_USER, root_proc, prio) sets the priorities of
> all the root processes to the specified value, though this is
> kind of expected for the test, it impacts the system environment.
>
> Create a new user and set it privileged, then test with the temp
> user id to ensure the test safety.
I've dropped all the capability stuff from the patch since the call to
setpriority() is now done in the main test process that runs under the
root. The child is create just so that we have a process whoose priority
will be changed.
Pushed with that change, thanks.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2017-01-04 12:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-30 12:12 [LTP] [PATCH 1/5] Cleanup && Drop redundant space in safe macros Guangwen Feng
2016-11-30 12:12 ` [LTP] [PATCH 2/5] SAFE_MACROS: Add SAFE_SETPRIORITY() Guangwen Feng
2016-11-30 12:12 ` [LTP] [PATCH 3/5] SAFE_MACROS: Add SAFE_SYSTEM() Guangwen Feng
2016-12-05 14:33 ` Cyril Hrubis
2016-12-06 10:02 ` Guangwen Feng
2016-11-30 12:12 ` [LTP] [PATCH 4/5] SAFE_MACROS: Add SAFE_PRCTL() Guangwen Feng
2016-12-05 14:40 ` Cyril Hrubis
2016-12-15 10:17 ` Guangwen Feng
2016-12-15 10:43 ` Cyril Hrubis
2016-12-15 10:49 ` [LTP] [PATCH v2 1/4] Cleanup && Drop redundant space in safe macros Guangwen Feng
2016-12-15 10:49 ` [LTP] [PATCH v2 2/4] SAFE_MACROS: Add SAFE_SETPRIORITY() Guangwen Feng
2016-12-15 10:49 ` [LTP] [PATCH v2 3/4] SAFE_MACROS: Add SAFE_PRCTL() Guangwen Feng
2016-12-15 10:49 ` [LTP] [PATCH v2 4/4] syscalls/setpriority01: Use new user id to avoid messing system environment Guangwen Feng
2017-01-04 12:13 ` Cyril Hrubis [this message]
2016-11-30 12:12 ` [LTP] [PATCH 5/5] " Guangwen Feng
2016-12-05 14:45 ` Cyril Hrubis
2016-12-06 10:27 ` Guangwen Feng
2016-12-06 10:34 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170104121333.GA7680@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox