From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 4/4] mmapstress03: Fix 32bit test on 64bit kernel
Date: Thu, 12 Jan 2017 16:05:51 +0100 [thread overview]
Message-ID: <20170112150550.GA5381@rei.lan> (raw)
In-Reply-To: <1342382447.1910370.1484232088575.JavaMail.zimbra@redhat.com>
Hi!
> > /* Ask for a ridiculously large mmap region at a high address */
> > - if (mmap((void*) (1UL << (POINTER_SIZE - 1)) - pagesize,
> > - (size_t) ((1UL << (POINTER_SIZE - 1)) - pagesize),
> > + if (mmap((void*) (1UL << (kernel_bits - 1)) - pagesize,
>
> Since this has same range as below, shouldn't it be also 1ULL?
> Entire series looks OK to me.
Hmm, that produces warnings in case that sizeof(void) == 4 and with
64bit kernel since the value is truncated. I guess that the addres
should be generated accordingly to the binary and not kernel after all
because of address space limitations.
Something as (((uintptr_t)1) << ((sizeof(void*)<<3) - 1) - pagesize)
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2017-01-12 15:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-12 13:23 [LTP] [PATCH 1/4] lib: Add tst_kernel_bits() Cyril Hrubis
2017-01-12 13:23 ` [LTP] [PATCH 2/4] vma03: Disable the test on 64bit kernel as well Cyril Hrubis
2017-01-12 13:23 ` [LTP] [PATCH 3/4] mmapstress03: Small cleanup Cyril Hrubis
2017-01-12 13:23 ` [LTP] [PATCH 4/4] mmapstress03: Fix 32bit test on 64bit kernel Cyril Hrubis
2017-01-12 14:41 ` Jan Stancek
2017-01-12 15:05 ` Cyril Hrubis [this message]
2017-01-12 16:41 ` Jan Stancek
2017-01-12 17:00 ` Cyril Hrubis
2017-01-12 17:00 ` Jan Stancek
2017-01-12 14:40 ` [LTP] [PATCH 1/4] lib: Add tst_kernel_bits() Jan Stancek
2017-01-12 14:45 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170112150550.GA5381@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox