public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] rt_sigtimedwait01: fix probability of failure
Date: Mon, 16 Jan 2017 14:33:20 +0100	[thread overview]
Message-ID: <20170116133302.GC26610@rei.lan> (raw)
In-Reply-To: <5863ACB5.8000606@huawei.com>

Hi!
>  	pid = getpid();
>  	WITH_SIGNALS_BLOCKED(if ((cpid = fork()) == 0) {
> @@ -138,6 +139,8 @@ pid_t create_sig_proc(unsigned long usec, int sig, unsigned count)
>  		EPRINTF("fork failed.\n");
>  		return cpid;
>  	default:
> +		/* wait cpid finish */

The comment here is redundant and useless.

> +		waitpid(cpid, &status, 0);
>  		return cpid;
>  	}
>  }
> -- 
> 1.8.3.4
> 
> 

-- 
Cyril Hrubis
chrubis@suse.cz

      reply	other threads:[~2017-01-16 13:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-13  9:09 [LTP] rt_sigtimedwait01 failed in armv7l Cui Bixuan
2016-12-13 10:43 ` Cyril Hrubis
2016-12-15  2:37   ` Cui Bixuan
2016-12-28 12:14     ` [LTP] [PATCH] rt_sigtimedwait01: fix probability of failure Cui Bixuan
2017-01-16 13:33       ` Cyril Hrubis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170116133302.GC26610@rei.lan \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox