From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH ltp] su01: do pre-checking to avoid annoying warning
Date: Wed, 18 Jan 2017 11:26:33 +0100 [thread overview]
Message-ID: <20170118102632.GA29948@rei.lan> (raw)
In-Reply-To: <1481849622-19704-1-git-send-email-ningx.han@intel.com>
Hi!
> ---
> testcases/commands/su/su01 | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/testcases/commands/su/su01 b/testcases/commands/su/su01
> index dd1517f..41441de 100755
> --- a/testcases/commands/su/su01
> +++ b/testcases/commands/su/su01
> @@ -86,7 +86,7 @@ rm -f $TEST_ENV_FILE > /dev/null 2>&1
> #Create 1st test user
> #erase user if he may exist , so we can have a clean en
> rm -rf /home/$TEST_USER1
> - userdel $TEST_USER1
> + getent passwd $TEST_USER1 &> /dev/null && userdel $TEST_USER1
^
This is a bashism, portable way to
redirect both streams is > /dev/null 2>&1
Upon closer look I've found and fixed two cases of bashism and pushed,
thanks.
--
Cyril Hrubis
chrubis@suse.cz
prev parent reply other threads:[~2017-01-18 10:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-16 0:53 [LTP] [PATCH ltp] su01: do pre-checking to avoid annoying warning Ning, Han
2017-01-18 10:26 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170118102632.GA29948@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox