From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/2] ipc/libnewipc.c: add CREATE_MSG to optimize duplicate code
Date: Thu, 19 Jan 2017 15:39:03 +0100 [thread overview]
Message-ID: <20170119143903.GC9193@rei.lan> (raw)
In-Reply-To: <1481860457-23035-1-git-send-email-yangx.jy@cn.fujitsu.com>
Hi!
> +int create_msg(const char *file, const int lineno, key_t key, int msgflg);
> +#define CREATE_MSG(key, msgflg) \
> + create_msg(__FILE__, __LINE__, key, msgflg)
Looking at this, we should rather start tst_safe_sysv_ipc.h and
implement it as SAFE_MSGGET() so that possibly reusable outside the ipc
directory as well.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2017-01-19 14:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-16 3:54 [LTP] [PATCH 1/2] ipc/libnewipc.c: add CREATE_MSG to optimize duplicate code Xiao Yang
2016-12-16 3:54 ` [LTP] [PATCH 2/2] ipc/msgsnd0*: cleanup && convert to new API Xiao Yang
2016-12-27 7:44 ` Xiao Yang
2017-01-19 15:21 ` Cyril Hrubis
2017-01-19 14:39 ` Cyril Hrubis [this message]
2017-01-23 10:31 ` [LTP] [PATCH v2 1/3] lib/tst_safe_sysv_ipc.c : Add tst_safe_sysv_ipc.c Xiao Yang
2017-01-23 10:31 ` [LTP] [PATCH v2 2/3] ipc/msgget0*: Make use of IPC related macros Xiao Yang
2017-01-23 13:02 ` Cyril Hrubis
2017-01-23 10:31 ` [LTP] [PATCH v2 3/3] ipc/msgsnd0*: cleanup && convert to new API Xiao Yang
2017-01-23 14:23 ` Cyril Hrubis
2017-01-23 13:02 ` [LTP] [PATCH v2 1/3] lib/tst_safe_sysv_ipc.c : Add tst_safe_sysv_ipc.c Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170119143903.GC9193@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox