From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/2] test_net.sh: add tst_set_sysctl()
Date: Tue, 31 Jan 2017 13:41:29 +0100 [thread overview]
Message-ID: <20170131124128.GF29227@rei.lan> (raw)
In-Reply-To: <4017cf9c-3957-0a91-4fa3-8bafdad2f4c4@oracle.com>
Hi!
> >> +# tst_set_sysctl NAME VALUE [safe]
> >> +# It can handle netns case when sysctl not namespaceified.
> >> +tst_set_sysctl()
> >> +{
> >> + local name="$1"
> >> + local value="$2"
> >> + local safe=
> >> + [ "$3" = "safe" ] && safe="-s" || safe=""
> > Uh, this syntax is confusing, besides isn't safe set to empty string
> > anyway?
>
> What if we set TST_NO_CLEANUP just before calling cleanup()
> or unset TST_CLEANUP... then we can use ROD, etc. in cleanup?
You lost me here. How is this connected to the code I've commented?
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2017-01-31 12:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-25 14:21 [LTP] [PATCH 1/2] test_net.sh: add tst_set_sysctl() Alexey Kodanev
2017-01-25 14:21 ` [LTP] [PATCH 2/2] net: dctcp01: apply tst_set_sysctl() Alexey Kodanev
2017-01-31 10:07 ` [LTP] [PATCH 1/2] test_net.sh: add tst_set_sysctl() Cyril Hrubis
2017-01-31 11:27 ` Alexey Kodanev
2017-01-31 12:41 ` Cyril Hrubis [this message]
2017-01-31 13:38 ` Alexey Kodanev
2017-01-31 15:23 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170131124128.GF29227@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox