From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] [RFC] zram01: Fix on ppc64le
Date: Wed, 8 Feb 2017 12:10:56 +0100 [thread overview]
Message-ID: <20170208111055.GA16139@rei.lan> (raw)
In-Reply-To: <20170202152242.GA11304@rei.lan>
Hi!
> > > What exactly do you have in mind? Using 256MB by default for any Btrfs
> > > filesystem or fallback to 256MB if mkfs.btrfs output cannot be parsed?
> >
> > I meant default size.
>
> Then we should increase the default size for the LTP_DEV as well.
> Unfortunately it's defined at three different places at this point. We
> have it in runltp script, the C library and the shell library. I was
> thinking of exporting the C library as a binary for the shell tests to
> use in order to reduce the complexity. I will look into that and also
> bump the minimal size as well.
And apparenlty it was defined in four different places, since we have two
versions of shell library each with it's own code to acquire device.
I've send a patchset that exports the acquire/release interface from C
as a single binary and makes use of that in the tst_test.sh.
There is still one unsolved problem since the TWARN messages from the
tst_device.c will trigger TBROK in tst_test.c since the IPC is not
initialized. I'm still unsure how to fix that, maybe we should allow to
allocate non-shared structure for the results in the special case that
the library code is being reused in shell helpers.
Finally the last patch of the series bumps the minima size to 256MB and
touched only two places, the runltp script and tst_device.c, which is
way better than four...
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2017-02-08 11:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-31 13:44 [LTP] [PATCH] [RFC] zram01: Fix on ppc64le Cyril Hrubis
2017-01-31 16:14 ` Jan Stancek
2017-02-01 9:45 ` Cyril Hrubis
2017-02-01 10:59 ` Jan Stancek
2017-02-02 15:22 ` Cyril Hrubis
2017-02-08 11:10 ` Cyril Hrubis [this message]
2017-02-09 12:02 ` Cyril Hrubis
2017-02-09 13:24 ` Jan Stancek
2017-02-09 14:00 ` Cyril Hrubis
2017-02-09 14:48 ` Jan Stancek
2017-02-09 14:56 ` Cyril Hrubis
2017-08-15 9:23 ` Cyril Hrubis
2017-08-15 11:44 ` Jan Stancek
2017-08-15 12:38 ` Cyril Hrubis
2017-08-15 12:48 ` Jan Stancek
2017-08-15 12:57 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170208111055.GA16139@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox